hkc
/
mastoposter
2
0
Fork 2
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improvements to Docker Image (Proper Layers Order and Docker-Ignore) #1

Closed
vapronva wants to merge 4 commits from vapronva/mastoposter-oss_images:master into master
pull from: vapronva/mastoposter-oss_images:master
merge into: hkc:master
Conversation 2 Commits 4 Files Changed 4 +75 -2
vapronva commented 2022-09-30 02:50:20 +03:00
First-time contributor
Copy Link

Why?

Prerequisites

“— 🤓”

Main Message

This project uses Docker as a way to run the application. Hence, some guidelines for creating Docker images should be followed.

What?

The single commit in this pull request includes:

  • added .dockerignore file — ensure no funky files are being added to the image
  • changed Dockerfile file — proper order of layers and commands (static instructions are executed first)
## Why? ### Prerequisites “— 🤓” ### Main Message This project uses Docker as a way to run the application. Hence, some guidelines for creating Docker images should be followed. ## What? The single commit in this pull request includes: * added `.dockerignore` file — ensure no [funky](https://youtu.be/7h7bnYA1LXE?t=24) files are being added to the image * changed `Dockerfile` file — proper order of layers and commands (static instructions are executed first)
vapronva added 1 commit 2022-09-30 02:50:23 +03:00
vapronva added 1 commit 2022-09-30 04:08:39 +03:00
vapronva commented 2022-09-30 04:20:57 +03:00
Author
First-time contributor
Copy Link

oh wow, forgor to switch the repositories was pushing to... and, huh, idk how to keep only that one commit from entering the pull request :sadge:

oh wow, forgor to switch the repositories was pushing to... and, huh, idk how to keep only that one commit from entering the pull request :sadge:
vapronva added 1 commit 2022-09-30 04:49:45 +03:00
vapronva added 1 commit 2022-09-30 05:00:50 +03:00
vapronva commented 2022-09-30 05:26:54 +03:00
Author
First-time contributor
Copy Link

sorry for my dumbness, will close now, reopen with a proper different branch

sorry for my dumbness, will close now, reopen with a proper different branch
vapronva closed this pull request 2022-09-30 05:27:00 +03:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hkc/mastoposter#1
No description provided.
Delete Branch "vapronva/mastoposter-oss_images:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?